Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Aug 9, 2023

FEA-2357

Issue Status

While support for indexing relationships was added, it was discovered that the results are not exactly accurate

This pr puts the functionality of indexing relationships behind a flag: --index-relationships to be worked on before its ready to be enabled by default

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review August 10, 2023 16:15
@bender-wk bender-wk changed the title Put relationship indexing behind a flag FEA-2357: Put relationship indexing behind a flag Aug 10, 2023
url: "https://pub.dartlang.org"
source: hosted
version: "2.4.2"
version: "2.4.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, thats strange

I did run a pubclean + pubget, I wonder if for whatever reason the pubspec.lock got upgraded past what a clean install results in?

@matthewnitschke-wk
Copy link
Contributor Author

matthewnitschke-wk commented Aug 10, 2023

QA +1

  • CI passes, only changes to snapshots were to remove relationships when --index-relationships is false

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants